-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add tooltip documentation to web request and brush related nodes #3427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Keavon
merged 5 commits into
GraphiteEditor:master
from
PolyglotOpenstreetmap:docs/add-node-tooltips
Jan 13, 2026
Merged
Add tooltip documentation to web request and brush related nodes #3427
Keavon
merged 5 commits into
GraphiteEditor:master
from
PolyglotOpenstreetmap:docs/add-node-tooltips
Jan 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
reviewed
Nov 27, 2025
TrueDoctor
reviewed
Nov 27, 2025
Keavon
reviewed
Nov 27, 2025
Keavon
reviewed
Nov 27, 2025
Member
|
@PolyglotOpenstreetmap can you address the remaining comments? |
Contributor
Author
|
I made a new commit, POST was commented with a message about GET. |
Member
|
Pinging @Keavon |
124235a to
a42cad8
Compare
- Add descriptive tooltips to web request nodes (GET/POST, string/image conversion, resource loading, image decoding) - Add tooltip to GPU rasterization node explaining footprint usage - Improve text node tooltip with clearer per_glyph_instances parameter explanation - Add tooltips to brush stamp generator and blit operations explaining their internal roles - Fix typos in tooltip and variable names (it's→its, perview→preview, instnace→instance)
… about per_glyph_instances. Can it be 3 lines?
Change doc comment to describe the node's purpose rather than focusing only on the "Discard Result" parameter. Now clearly states this is an HTTP POST operation with optional async behavior.
Corrected doc comment to say "HTTP POST" instead of "HTTP GET" since this function performs POST requests with binary data.
5bcb72b to
430df53
Compare
Keavon
approved these changes
Jan 13, 2026
Member
Keavon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Sorry for the delays in merging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.