Skip to content

Conversation

@PolyglotOpenstreetmap
Copy link
Contributor

@PolyglotOpenstreetmap PolyglotOpenstreetmap commented Nov 27, 2025

  • Add descriptive tooltips to web request nodes (GET/POST, string/image conversion, resource loading, image decoding)
  • Add tooltip to GPU rasterization node explaining footprint usage
  • Add tooltips to brush stamp generator and blit operations explaining their internal roles
  • Fix typos in tooltip and variable names

@TrueDoctor
Copy link
Member

@PolyglotOpenstreetmap can you address the remaining comments?

@PolyglotOpenstreetmap
Copy link
Contributor Author

I made a new commit, POST was commented with a message about GET.

@TrueDoctor
Copy link
Member

Pinging @Keavon

PolyglotOpenstreetmap and others added 5 commits January 13, 2026 00:06
  - Add descriptive tooltips to web request nodes (GET/POST, string/image conversion, resource loading, image decoding)
  - Add tooltip to GPU rasterization node explaining footprint usage
  - Improve text node tooltip with clearer per_glyph_instances parameter explanation
  - Add tooltips to brush stamp generator and blit operations explaining their internal roles
  - Fix typos in tooltip and variable names (it's→its, perview→preview, instnace→instance)
… about per_glyph_instances. Can it be 3 lines?
Change doc comment to describe the node's purpose rather than focusing
only on the "Discard Result" parameter. Now clearly states this is an
HTTP POST operation with optional async behavior.
Corrected doc comment to say "HTTP POST" instead of "HTTP GET" since
this function performs POST requests with binary data.
@Keavon Keavon force-pushed the docs/add-node-tooltips branch from 5bcb72b to 430df53 Compare January 13, 2026 08:20
@Keavon Keavon changed the title Add tooltip documentation to web request, text, and brush nodes Add tooltip documentation to web request and brush nodes Jan 13, 2026
@Keavon Keavon changed the title Add tooltip documentation to web request and brush nodes Add tooltip documentation to web request and brush related nodes Jan 13, 2026
Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Sorry for the delays in merging it.

@Keavon Keavon enabled auto-merge (squash) January 13, 2026 08:21
@Keavon Keavon merged commit e3ad59a into GraphiteEditor:master Jan 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants